Improve workflow examples#949
Merged
artursouza merged 23 commits intoDec 4, 2023
Merged
Conversation
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Contributor
Author
|
I cannot add reviewers due to permission issues on this repo. Tagging @johnewart , @cgillum, @artursouza , @cicoyle for review. |
cgillum
reviewed
Nov 8, 2023
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Overall looks good to me! Just a few small things I noticed.
kaibocai
force-pushed
the
kaibocai/improve-workflow-examples
branch
from
b1c6aaa to
65c83ad
Compare
mukundansundar
suggested changes
Nov 8, 2023
mukundansundar
left a comment
mukundansundar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution.
A few comments to add auto validation mechanical-markdown script to README and removal of gRPC update and have it as a separate one if possible.
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Contributor
|
This is great - thanks for enhancing the workflow example 🎉 It looks like you may need to tweak the port, since the build is failing due to the port not being available, but looks good 👍🏻 |
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
kaibocai
force-pushed
the
kaibocai/improve-workflow-examples
branch
from
256849f to
3eef63e
Compare
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Contributor
Author
|
Hi @artursouza , @cicoyle and @mukundansundar . I need some help on the Auto Validate Examples, I could not figure out the right configuration. However, everything works as expected on my local. Thanks. |
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: Kaibo Cai (from Dev Box) <kaibocai@microsoft.com>
artursouza
suggested changes
Nov 27, 2023
| Once you start the workflow and client using the following commands: | ||
| ```sh | ||
| dapr run --app-id demoworkflowworker --resources-path ./components/workflows --dapr-grpc-port 50001 -- java -jar target/dapr-java-sdk-examples-exec.jar io.dapr.examples.workflows.DemoWorkflowWorker | ||
| dapr run --app-id demoworkflowworker --resources-path ./components/workflows -- java -jar target/dapr-java-sdk-examples-exec.jar io.dapr.examples.workflows.continueasnew.DemoContinueAsNewWorker |
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
kaibocai
changed the title
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
=========================================
Coverage 76.54% 76.54%
Complexity 1467 1467
=========================================
Files 137 137
Lines 4472 4472
Branches 527 527
=========================================
Hits 3423 3423
Misses 763 763
Partials 286 286 ☔ View full report in Codecov by Sentry. |
artursouza
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
Chaining Pattern
Fan-out/Fan-in Pattern
Continue As New Pattern
External Event Pattern
Sub-workflow Pattern
This PR is based on #947, and should be merged after it.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #944, #911
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: